Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dockerise gateway #9

Conversation

tom-schier
Copy link

Checklist: (Put an x in all the boxes that apply)

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All new and existing tests passed.
  • I have checked that there aren't any other open Pull Requests from the same change.
  • The develop branch has been set as the base branch to merge changes of the pull request.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

What is the current behavior? (You can also link to an open issue here)

Gateways cannot be created as isolated containers.

What is the new behavior? (if this is a feature change)

Ability to create gateways as docker containers

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No. This functionality sits on top.

Other information:

@CDR-AndrewG
Copy link
Contributor

Hi @tom-schier,

Thank you for raising this PR.

To help us review and confirm the changes required for the authorisation-server, we need information regarding why the changes are required and why the current offering does not provide what is needed. Please use the feature request template to provide more details and link the feature to the Pull Request.

Some of the questions we have are:

  • What use case(s) does hosting the authorisation-server gateways outside of the existing docker container support?
  • How would a user run the authorisation-server docker container whilst also utilising the gateway docker containers?
  • What behaviour is experienced when using the new gateway docker containers with the existing authorisation-server docker container?
  • How can testing of the gateway docker containers be automated so they are not impacted by a future release and maintenance overheads are reduced?

Once we get through the requirements and feature confirmation, there will be a couple of additions needed:

  • Creation of automated tests
  • Update added to the changelog
  • Depending on how the feature works, documentation changes will most likely be required

@stale
Copy link

stale bot commented Oct 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 22, 2023
@stale stale bot closed this Oct 28, 2023
@CDR-HansenS CDR-HansenS reopened this Oct 31, 2023
@stale stale bot removed the wontfix This will not be worked on label Oct 31, 2023
@cdr-mustafa
Copy link

Hi @tom-schier

TLS and MTLS gateways are tightly coupled with the authorisation-server and serve routing to the authorisation-server on specific hostnames and ports in a local development environment.

Moving TLS and MTLS gateways out into their own container images might not benefit the community. Additionally, it will require the community to design and configure their auth server implementation in a specific way that aligns with these TLS and MTLS gateways.

Copy link

stale bot commented Nov 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 20, 2023
@stale stale bot closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants